New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement optional HMAC verification of incoming /issue/credentials requests #17

Closed

rhysyngsun opened this issue Oct 29, 2020 · 0 comments · Fixed by #18

Assignees

Contributor

rhysyngsun commented Oct 29, 2020

This will verify the incoming request using a shared HMAC secret, it will give a guarantee that the request is from a trusted source.

This draft spec seems to suit this requirement: https://tools.ietf.org/html/draft-ietf-httpbis-message-signatures-00

This library is a node implementation: https://github.com/joyent/node-http-signature/

rhysyngsun self-assigned this

This was referenced Nov 3, 2020

Updated request structure and added HMAC signature mitodl/ol-django#18

Merged

Added HMAC verification #18

Merged

rhysyngsun closed this as completed in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment