Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Make use of location_not_on_map attribute #1038

Closed
Tracked by #1039
svenseeberg opened this issue Nov 24, 2021 · 4 comments · Fixed by #1342
Closed
Tracked by #1039

API: Make use of location_not_on_map attribute #1038

svenseeberg opened this issue Nov 24, 2021 · 4 comments · Fixed by #1342
Assignees
@jonbulz
Labels
🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request
Milestone
Migration

Comments

@svenseeberg
Copy link
Member

svenseeberg commented Nov 24, 2021 •
edited

We have POIs for several use cases in Integreat. We only want the most important POIs to be shown on the map by default (at least in the prototype / demo version).

  1. Invert the location_not_on_map attribute of the POI model - so rename it to location_on_map and set it to True per default
  2. Make use of the attribute. We could provide 2 API endpoints for the app:
    • One endpoint delivers all POIs with this attribute.
    • The other endpoint filters POIs by location_on_map = True
@svenseeberg svenseeberg added the 💡 feature New feature or request label Nov 24, 2021
@svenseeberg svenseeberg added this to the Version 1.2 milestone Nov 24, 2021
@timobrembeck
Copy link
Member

This is already implemented:
Screenshot 2021-11-24 at 14-24-08 Integreat Redaktionssystem

@svenseeberg svenseeberg mentioned this issue Nov 24, 2021
Open
7 tasks
@svenseeberg
Copy link
Member Author

Is this attribute delivered via the API or is the API content filtered by this attribute?

@timobrembeck
Copy link
Member

Oh funny, it's completely unused at the moment.

@timobrembeck timobrembeck changed the title Show POI on map attribute Make use of location_not_on_map attribute Nov 24, 2021
@timobrembeck timobrembeck reopened this Nov 24, 2021
@svenseeberg
Copy link
Member Author

svenseeberg commented Nov 24, 2021 •
edited

We could provide 2 API endpoints:

  • One endpoint delivers all POIs with this attribute.
  • The other endpoint filters POIs by location_not_on_map = True

Both may be needed by the app in the future.

@timobrembeck timobrembeck added the 🍼 good first issue Good for newcomers label Nov 24, 2021
@jonbulz jonbulz mentioned this issue Apr 4, 2022
Merged
@svenseeberg svenseeberg added the ‼️ prio: high Needs to be resolved ASAP. label Apr 27, 2022
@svenseeberg svenseeberg changed the title Make use of location_not_on_map attribute API: Make use of location_not_on_map attribute Apr 27, 2022
@timobrembeck timobrembeck mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonbulz jonbulz

Labels
🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request
Projects
None yet
Milestone
Migration
Development

Successfully merging a pull request may close this issue.

Filter locations in API by location_on_map field digitalfabrik/integreat-cms
4 participants
@svenseeberg @ulliholtgrave @timobrembeck @jonbulz