Improve production setup #1044
Merged
Improve production setup #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the Debug mode to be activated without manually installing django-debug-toolbar
After updating pylint to version 2.12.2, packed function arguments need to be documented with a starting asterisk (which in turn has to be escaped in order for Sphinx to recognize it). See pylint-dev/pylint#5472 for reference.
- Enable more settings to be set via environment variables - Change the environment variable prefix from "DJANGO_" to "INTEGREAT_CMS_" - Correctly parse boolean values that are passed as strings
timobrembeck
force-pushed
the
enhancement/production-setup
branch
from
a189ab0
to
1b4b365
Compare
timobrembeck
force-pushed
the
enhancement/production-setup
branch
from
1b4b365
to
143b57e
Compare
timobrembeck
force-pushed
the
enhancement/production-setup
branch
from
143b57e
to
a67dcc3
Compare
ulliholtgrave
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This adds various improvements for the production setup routine.
Proposed changes
setup.pyagain (This makes it easier to install the debug dependencies via pip, e.g.pip install integreat-cms[debug])SECRET_KEY- Django already handles empty keysDJANGO_toINTEGREAT_CMS_/etc/integreat-cms.iniMANIFEST.infile to exclude some more files from the packageUnfortunately,
pipenv lock -r > requirements.txtoutputs all dependencies including dev dependencies and I found no way to exclude them. So for now, we don't have a good way to make sure the package versions on the dev environment and the production server match.