Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when trying to delete a poi #1077

Merged
merged 1 commit into from Jan 5, 2022

Conversation

david-venhoff
Copy link
Member

Short Description

Before this pr, the server crashed when trying to delete a poi that is referenced by an event.
This pr disables deleting pois that are still used by at least one event

Co-authored-by: philip popien membralala@users.noreply.github.com
Co-authored-by: MizukiTemma MizukiTemma@users.noreply.github.com

@david-venhoff david-venhoff requested a review from a team as a code owner January 4, 2022 18:01
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍
This works as expected, just have a few minor comments.

integreat_cms/cms/templates/pois/poi_form.html Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍
Could you add this fix to the CHANGELOG.md and resolve the conflict in the translation file?

@david-venhoff david-venhoff force-pushed the bugfix/delete_pois_with_event branch 3 times, most recently from fa0c9f8 to d31c1f0 Compare January 5, 2022 10:39
CHANGELOG.md Outdated Show resolved Hide resolved
that is referenced by an event

Co-authored-by: philip popien <membralala@users.noreply.github.com>
Co-authored-by: MizukiTemma <MizukiTemma@users.noreply.github.com>

Update integreat_cms/cms/templates/pois/poi_form.html

Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>

Update integreat_cms/locale/de/LC_MESSAGES/django.po

Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>

Update integreat_cms/locale/de/LC_MESSAGES/django.po

Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>

Update integreat_cms/locale/de/LC_MESSAGES/django.po

Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>

Update integreat_cms/locale/de/LC_MESSAGES/django.po

Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>

include functionality for archived pois
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks! 😍

@david-venhoff david-venhoff merged commit 57d2a9a into develop Jan 5, 2022
@david-venhoff david-venhoff deleted the bugfix/delete_pois_with_event branch January 5, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants