New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a crash when trying to delete a poi #1077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 👍
This works as expected, just have a few minor comments.
8ca2fca
to
c473dc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 👍
Could you add this fix to the CHANGELOG.md and resolve the conflict in the translation file?
fa0c9f8
to
d31c1f0
Compare
d31c1f0
to
4cef872
Compare
that is referenced by an event Co-authored-by: philip popien <membralala@users.noreply.github.com> Co-authored-by: MizukiTemma <MizukiTemma@users.noreply.github.com> Update integreat_cms/cms/templates/pois/poi_form.html Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/locale/de/LC_MESSAGES/django.po Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/locale/de/LC_MESSAGES/django.po Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/locale/de/LC_MESSAGES/django.po Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> Update integreat_cms/locale/de/LC_MESSAGES/django.po Co-authored-by: Timo Ludwig <ludwig@integreat-app.de> include functionality for archived pois
4cef872
to
d2185ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks! 😍
Short Description
Before this pr, the server crashed when trying to delete a poi that is referenced by an event.
This pr disables deleting pois that are still used by at least one event
Co-authored-by: philip popien membralala@users.noreply.github.com
Co-authored-by: MizukiTemma MizukiTemma@users.noreply.github.com