Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal links when cloning regions #1383

Closed
Tracked by #1704
svenseeberg opened this issue May 3, 2022 · 2 comments · Fixed by #2126
Closed
Tracked by #1704

Update internal links when cloning regions #1383

svenseeberg opened this issue May 3, 2022 · 2 comments · Fixed by #2126
Assignees
Labels
💡 feature New feature or request ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?)
Milestone

Comments

@svenseeberg
Copy link
Member

Motivation

When a region is cloned, all links in the content still point to pages in the old region. However, in almost all cases these links should point to pages in the newly created region. We're already planing to have a centralized search & replace function. This function can be used to update all pages when cloning a region. This prevents any human errors that could occur when manually replacing the URLs.

Proposed Solution

Call the search & replace function created in #1382 to replace the base URL + region slug for all pages (including all versions if easily possible) without adding new page versions. A minor edit should be okay.

@svenseeberg svenseeberg added the 💡 feature New feature or request label May 3, 2022
@svenseeberg svenseeberg added this to the Version 1.3 milestone May 3, 2022
@ulliholtgrave ulliholtgrave added the ☺️ effort: low Should be doable in <4h label May 16, 2022
@timobrembeck
Copy link
Member

This either depends on #1414 or the media links have to be excluded from the replacement, otherwise the images will be broken.

@osmers osmers added ❗ prio: medium Should be scheduled in the forseeable future. and removed ❗ prio: medium Should be scheduled in the forseeable future. labels Sep 23, 2022
@timobrembeck timobrembeck modified the milestones: 22Q3, 22Q4 Oct 2, 2022
@ulliholtgrave ulliholtgrave modified the milestones: 22Q4, 23Q1 Nov 4, 2022
@svenseeberg svenseeberg added 🆘 prio: urgent Needs to be resolved now(?) and removed ❗ prio: medium Should be scheduled in the forseeable future. labels Feb 17, 2023
@svenseeberg svenseeberg changed the title Update links when cloning regions Update internal links when cloning regions Feb 17, 2023
@timobrembeck timobrembeck self-assigned this Mar 14, 2023
@timobrembeck
Copy link
Member

This either depends on #1414 or the media links have to be excluded from the replacement, otherwise the images will be broken.

My earlier statement is not true since media links use the region id and not the region slug in links. So replacing the region slug should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature New feature or request ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants