Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance issue for "select all" in big page trees #1404

Closed
ulliholtgrave opened this issue May 9, 2022 · 0 comments · Fixed by #1420
Closed

Fix performance issue for "select all" in big page trees #1404

ulliholtgrave opened this issue May 9, 2022 · 0 comments · Fixed by #1420
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working
Milestone
Migration

Comments

@ulliholtgrave
Copy link
Member

Describe the Bug

In very large page trees (e.g. Munich) clicking on the select all checkbox results in a browser crash.

Additional Information

This is probably a result of the used recursion in the implementation. This could be fixed by just using a QuerySelectorAll as an event and remove the current implementation.
@ulliholtgrave ulliholtgrave added the 🐛 bug Something isn't working label May 9, 2022
@ulliholtgrave ulliholtgrave added this to the Version 1.1 milestone May 9, 2022
@svenseeberg svenseeberg added the ‼️ prio: high Needs to be resolved ASAP. label May 11, 2022
@ulliholtgrave ulliholtgrave mentioned this issue May 13, 2022
Merged
@timobrembeck timobrembeck mentioned this issue May 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working
Projects
None yet
Milestone
Migration
Development

Successfully merging a pull request may close this issue.

Fix performance issues for "select all" digitalfabrik/integreat-cms
2 participants
@svenseeberg @ulliholtgrave