Strip HTML in excerpt field and adjust test data #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks, works as expected! 👍
Is there a reason you didn't use the inbuilt Django functionality?
from django.utils.html import strip_tags
excerpt": strip_tags(page_translation.content),
I feel like a custom html parser is a bit overkill for this task...
Apart from that: could you add a note to the changelog?
ulliholtgrave
force-pushed
the
bugfix/excerpt_creation
branch
from
e0fa2d3
to
c8a40c4
Compare
|
Code Climate has analyzed commit f00872f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.5% (0.0% change). View more on Code Climate. |
|
@timoludwig You are right, i just missed this inbuild method and changed it accordingly. I also added a Changelog entry and fixed all the test cases (which was a hell of a job 🙈 ) |
timobrembeck
approved these changes
May 12, 2022
ulliholtgrave
force-pushed
the
bugfix/excerpt_creation
branch
from
c8a40c4
to
f00872f
Compare
ulliholtgrave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a functionality to strip the HTML entities in the excerpt field and adjust the test data accordingly.
Resolved issues
Fixes: #1410