Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user list #1483

Merged
merged 2 commits into from May 25, 2022
Merged

Improve user list #1483

merged 2 commits into from May 25, 2022

Conversation

timobrembeck
Copy link
Member

@timobrembeck timobrembeck commented May 24, 2022

Short description

Improve user list

Proposed changes

  • Hide staff users from region user list
  • Add filters to admin user list

Resolved issues

Fixes: #1416

@timobrembeck timobrembeck requested a review from a team as a code owner May 24, 2022 08:29
@codeclimate
Copy link

codeclimate bot commented May 24, 2022

Code Climate has analyzed commit 6790643 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 65.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.6% (0.0% change).

View more on Code Climate.

@timobrembeck timobrembeck force-pushed the bugfix/users branch 4 times, most recently from 5acdc33 to 0093baa Compare May 24, 2022 19:23
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works as expected 👍

@timobrembeck timobrembeck merged commit fe8d5ee into develop May 25, 2022
@timobrembeck timobrembeck deleted the bugfix/users branch May 25, 2022 13:31
@timobrembeck timobrembeck mentioned this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to save staff users in region user form
2 participants