Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Icons in PDF export broken #1537

Closed
Tracked by #1533
svenseeberg opened this issue Jun 9, 2022 · 1 comment · Fixed by #1755
Closed
Tracked by #1533

Inline Icons in PDF export broken #1537

svenseeberg opened this issue Jun 9, 2022 · 1 comment · Fixed by #1755
Assignees
Labels
🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. 😱 effort: high Big change, which requires >12h
Milestone

Comments

@svenseeberg
Copy link
Member

Describe the Bug

When using icons within a line of text, the PDF export creates a white bar across the icon/image with the height of the text line. If the icon itself has about the height of the text, then the icon is mostly invisible. See https://integreat.app/testumgebung/de/alltag/information as an example.

Steps to Reproduce

  1. Create a page with an icon at the beginning and another in the middle of a line of text.
  2. Save the page and export a PDF
  3. See that the icon at the beginning of the line is fully visible, while the icon in the middle is partially hidden:
    image

Expected Behavior

Icons/images should be visible regardless of their position in text.

Actual Behavior

Only images at the beginning or outside of text work as expected.

Additional Information

I guess that this is a bug in https://github.com/xhtml2pdf/xhtml2pdf/

@svenseeberg svenseeberg added 🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. labels Jun 9, 2022
@svenseeberg svenseeberg added this to the 22Q2 milestone Jun 9, 2022
@svenseeberg svenseeberg mentioned this issue Jun 9, 2022
33 tasks
@svenseeberg svenseeberg added the 😱 effort: high Big change, which requires >12h label Jun 9, 2022
@ulliholtgrave ulliholtgrave modified the milestones: 22Q2, 22Q3 Jun 29, 2022
@timobrembeck timobrembeck modified the milestones: 22Q3, 22Q4 Oct 2, 2022
@charludo charludo self-assigned this Oct 11, 2022
@charludo
Copy link
Contributor

I've found the issue: in this xhtml2pdf file on line 403, setting the background color (any background color, doesn't matter the value - color, transparent, none,...) makes inline-icons disappear.

There's certainly some deeper underlying issue, the question is, is it worth looking into? We could simply use a version of this default css without that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ❗ prio: medium Should be scheduled in the forseeable future. 😱 effort: high Big change, which requires >12h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants