Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner for test systems #1547

Closed
timobrembeck opened this issue Jun 14, 2022 · 3 comments · Fixed by #2354
Closed

Add banner for test systems #1547

timobrembeck opened this issue Jun 14, 2022 · 3 comments · Fixed by #2354
Assignees
Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@timobrembeck
Copy link
Member

Motivation

Sometimes, it can be dangerous to mix up the test and prod systems.

Proposed Solution

  • Add new TEST setting independently from DEBUG mode
  • Also support reading this setting from environment variables
  • When this setting is True, add a test banner at the top of the screen

Alternatives

Additional Context

Just for reference, e.g. PyPI does it the following way:

https://pypi.org/
Screenshot 2022-06-14 at 10-42-58 PyPI · The Python Package Index

https://test.pypi.org/
Screenshot 2022-06-14 at 10-43-15 TestPyPI · The Python Package Index

@timobrembeck timobrembeck added 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels Jun 14, 2022
@timobrembeck timobrembeck added this to the Backlog milestone Jun 14, 2022
@timobrembeck timobrembeck self-assigned this Jul 23, 2023
@timobrembeck timobrembeck modified the milestones: Backlog, 23Q3 Jul 23, 2023
@steffenkleinle
Copy link
Member

steffenkleinle commented Aug 3, 2023

@timoludwig the text of the banner is not 100% accurate, the content of test cms is not visible in our beta versions. It is only visible in webnext/dev releases of the native apps. Since its probably just for internal use, we might also keep it as it is as long as nobody complains.

@timobrembeck
Copy link
Member Author

@steffenkleinle ah ok, that's unfortunate. The banner should reduce confusion, not add to it. Do you want to open an issue and suggest a different wording?

@steffenkleinle
Copy link
Member

@timoludwig done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants