Improve wording of minor edit label #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit f376aa1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 87.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.0% (0.0% change). View more on Code Climate. |
timobrembeck
force-pushed
the
enhancement/minor-edit-label
branch
from
a7b7c6f
to
f7b6694
Compare
timobrembeck
force-pushed
the
enhancement/minor-edit-label
branch
from
f7b6694
to
f376aa1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Improve wording of minor edit label
Proposed changes
Before, the label always was "implications on other translations", but for translations that are not the default translation, this is not correct. For languages that are further down the language tree (either leaf nodes or somewhere between the default language and a leaf node), the minor edit field not only impacts the other translations, but the current translation as well.
This change of the wording reflects the actual implications of the minor edit field.