Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chat permission #1583

Closed
ulliholtgrave opened this issue Jun 30, 2022 · 3 comments · Fixed by #1671
Closed

Add chat permission #1583

ulliholtgrave opened this issue Jun 30, 2022 · 3 comments · Fixed by #1671
Assignees
@JoeyStk
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone
22Q3

Comments

@ulliholtgrave
Copy link
Member

ulliholtgrave commented Jun 30, 2022 •
edited by timobrembeck

Motivation

Right now every role can see the chat if it is activated for a region. In the old system the chat was only visible to the "Verwalter" role.

Proposed Solution

  • Add the "change" permission to the chat message model and give it to the "Verwalter" and all IG roles
@ulliholtgrave ulliholtgrave added 💡 feature New feature or request 🍼 good first issue Good for newcomers ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels Jun 30, 2022
@ulliholtgrave ulliholtgrave added this to the 22Q3 milestone Jun 30, 2022
@timobrembeck
Copy link
Member

The chat is already enabled by default:

integreat-cms/integreat_cms/cms/models/regions/region.py

Lines 245 to 246 in 839ceea

chat_enabled = models.BooleanField(
default=True,

@ulliholtgrave
Copy link
Member Author

ulliholtgrave commented Jun 30, 2022 •
edited

I updated the issue.

@ulliholtgrave ulliholtgrave changed the title Add chat permission and activate chat by default for regions Add chat permission Jun 30, 2022
@ulliholtgrave
Copy link
Member Author

As we are already touching the chat widget we should also come up with an idea about how we handle the widgets if statistics and chat are disabled. Our current implementation leaves a big blank whole in the middle of the screen.

@JoeyStk JoeyStk self-assigned this Aug 25, 2022
@JoeyStk JoeyStk mentioned this issue Sep 7, 2022
Merged
@timobrembeck timobrembeck mentioned this issue Sep 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeyStk JoeyStk

Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
22Q3
Development

Successfully merging a pull request may close this issue.

Add chat permission and give deletion rights to service team digitalfabrik/integreat-cms
3 participants
@ulliholtgrave @timobrembeck @JoeyStk