Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing default translations in translation coverage #1596

Closed
timobrembeck opened this issue Jul 14, 2022 · 3 comments · Fixed by #1607
Closed

Ignore missing default translations in translation coverage #1596

timobrembeck opened this issue Jul 14, 2022 · 3 comments · Fixed by #1607
Assignees
Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. 🌈 ui-ux Issues that requires an UI/UX perspective. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@timobrembeck
Copy link
Member

Motivation

When the translations in the default language are either "in review" or "draft", the translation status is considered "missing".
This is confusing in the translation coverage view, since we only want to know how many translations need to be translated by professional translators, not how many pages need content revisions.

Proposed Solution

Ignore missing translations in the default language in the translation coverage view.
These translations should also be ignored in all other languages and not counted as missing/outdated words.

Alternatives

Additional Context

@timobrembeck timobrembeck added 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels Jul 14, 2022
@timobrembeck timobrembeck added this to the 22Q4 milestone Jul 14, 2022
@svenseeberg
Copy link
Member

I think changing the calculation for the default language would be more difficult and confusing than other solutions. I'd prefer one of the following solutions:

  • Drop the source language of a region completely from the view. It seems reasonable for users to not consider the source language a "translation" and therefore there is no expectation that the language would appear in the statistics.
  • Simply explain what is going on and what the graph is showing.

@dkehne
Copy link

dkehne commented Jul 14, 2022

Please speak to UI/UX to solve it useful. I like the idea more of Timo, than dropping of the source language or put in any more text.
it should be self-explaining...

@svenseeberg
Copy link
Member

it should be self-explaining...

It always should be. It never is, and we need to discuss how to get there.

@timobrembeck timobrembeck added 🔨 enhancement This improves an existing feature 🌈 ui-ux Issues that requires an UI/UX perspective. and removed 💡 feature New feature or request labels Jul 18, 2022
@ulliholtgrave ulliholtgrave self-assigned this Jul 26, 2022
@timobrembeck timobrembeck modified the milestones: 22Q4, 22Q3 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. 🌈 ui-ux Issues that requires an UI/UX perspective. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants