Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Notification sent but status not updated due to missing firebase response ID #1630

Closed
ulliholtgrave opened this issue Aug 11, 2022 · 0 comments · Fixed by #1740
Closed
Assignees
Labels
🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h
Milestone

Comments

@ulliholtgrave
Copy link
Member

Describe the Bug

One customer had a bug about sending a push notification. It was received on the smartphones, but it had a "not sent yet" status. In our log I found error which indicates that no id was created (see Traceback).

Additional Information

Traceback
Traceback (most recent call last):
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
  response = get_response(request)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
  response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/views/generic/base.py", line 70, in view
  return self.dispatch(request, *args, **kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/utils/decorators.py", line 43, in _wrapper
  return bound_method(*args, **kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
  return view_func(request, *args, **kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/views/generic/base.py", line 98, in dispatch
  return handler(request, *args, **kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/utils/decorators.py", line 43, in _wrapper
  return bound_method(*args, **kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
  return view_func(request, *args, **kwargs)
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/integreat_cms/cms/views/push_notifications/push_notification_form_view.py", line 255, in post
  if push_sender.send_all():
File "/opt/integreat-cms/.venv/lib/python3.9/site-packages/integreat_cms/cms/views/push_notifications/push_notification_sender.py", line 140, in send_all
  logger.info("%r sent, FCM id: %r", pnt, res.json()["message_id"])
KeyError: 'message_id'

@ulliholtgrave ulliholtgrave added the 🐛 bug Something isn't working label Aug 11, 2022
@timobrembeck timobrembeck added this to the 22Q3 milestone Aug 14, 2022
@timobrembeck timobrembeck added ‼️ prio: high Needs to be resolved ASAP. 😅 effort: medium Should be doable in <12h labels Aug 14, 2022
@timobrembeck timobrembeck modified the milestones: 22Q3, 22Q4 Oct 2, 2022
@timobrembeck timobrembeck self-assigned this Oct 6, 2022
@timobrembeck timobrembeck changed the title Push Notification couldn't be send due to missing id Push Notification sent but status not updated due to missing firebase response ID Oct 6, 2022
@timobrembeck timobrembeck added 🍼 good first issue Good for newcomers ☺️ effort: low Should be doable in <4h and removed 😅 effort: medium Should be doable in <12h labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants