Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language tree views #1674

Merged
merged 4 commits into from Sep 10, 2022
Merged

Improve language tree views #1674

merged 4 commits into from Sep 10, 2022

Conversation

timobrembeck
Copy link
Member

Short description

A few improvements for our language tree views

Proposed changes

  • Refactor language tree views to make use of the new generic views
  • Improve language tree node creation
    • Disable changing the language after a node has been created
    • Preselect the region's default language as source language
    • Add button to add more nodes
  • Generalize bulk action views
    • Make it easier to create new bulk actions which set boolean fields
  • Add bulk actions for language tree nodes

Resolved issues

Fixes: #1591

- Disable changing the language after a node has been created
- Preselect the region's default language as source language
- Add button to add more nodes
Make it easier to create new bulk actions which set boolean fields
@timobrembeck timobrembeck requested a review from a team as a code owner September 8, 2022 22:21
@codeclimate
Copy link

codeclimate bot commented Sep 8, 2022

Code Climate has analyzed commit e526495 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 87.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.2% (0.1% change).

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything works as expected and I like the idea of more generalization 👍

@timobrembeck timobrembeck merged commit 65ce25d into develop Sep 10, 2022
@timobrembeck timobrembeck deleted the refactoring/language-tree branch September 10, 2022 11:40
@timobrembeck timobrembeck mentioned this pull request Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bulk actions for language tree nodes
2 participants