Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable upload-test-coverage CircleCI job for PRs of forks #1762

Closed
Tracked by #765
timobrembeck opened this issue Oct 15, 2022 · 0 comments · Fixed by #1790
Closed
Tracked by #765

Disable upload-test-coverage CircleCI job for PRs of forks #1762

timobrembeck opened this issue Oct 15, 2022 · 0 comments · Fixed by #1790
Assignees
@seluianova
Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone
22Q4

Comments

@timobrembeck
Copy link
Member

Motivation

The upload-test-coverage job on CircleCI doesn't work for external PRs since we don't pass our secrets to builds in other forks of this repository, see e.g. this workflow run.

Proposed Solution

Find a way to disable the job or make it succeed without doing anything on external forks

Alternatives

Additional Context
@timobrembeck timobrembeck added ⁉️ prio: low Not urgent, can be resolved in the distant future. 🔨 enhancement This improves an existing feature ☺️ effort: low Should be doable in <4h labels Oct 15, 2022
@timobrembeck timobrembeck added this to the Backlog milestone Oct 15, 2022
@seluianova seluianova mentioned this issue Oct 24, 2022
Closed
@seluianova seluianova self-assigned this Oct 24, 2022
@seluianova seluianova mentioned this issue Oct 24, 2022
Merged
@seluianova seluianova linked a pull request Oct 24, 2022 that will close this issue
Disable upload-test-coverage CircleCI job for PRs of forks #1790
Merged
@timobrembeck timobrembeck modified the milestones: Backlog, 22Q4 Oct 25, 2022
@timobrembeck timobrembeck mentioned this issue Nov 3, 2022
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seluianova seluianova

Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
22Q4
Development

Successfully merging a pull request may close this issue.

Disable upload-test-coverage CircleCI job for PRs of forks digitalfabrik/integreat-cms
2 participants
@timobrembeck @seluianova