Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken translation status if only minor public versions exist #1788

Closed
Tracked by #1887
timobrembeck opened this issue Oct 24, 2022 · 0 comments · Fixed by #1854
Closed
Tracked by #1887

Broken translation status if only minor public versions exist #1788

timobrembeck opened this issue Oct 24, 2022 · 0 comments · Fixed by #1854
Assignees
Labels
🍼 good first issue Good for newcomers 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@timobrembeck
Copy link
Member

Describe the Bug

When a POI or Event is published as minor edit, the translation status shows "Fallback translation", which does not make sense.

Steps to Reproduce

  1. Create POI as draft
  2. Do not change content and publish - this should create a new versions which is marked as minor edit
  3. See translation status in language tab - it is marked as fallback translation

Expected Behavior

The translation should be up to date.
We can achieve this by setting all past versions to public, similar to how we do it for pages:

# When a version is published and a minor edit, also publish the past versions
# (to make sure the translation state is updated correctly)
if (
page_translation_form.instance.status == status.PUBLIC
and page_translation_form.instance.minor_edit
):
page_translation_form.instance.page.translations.filter(
language=language
).update(status=status.PUBLIC)

Actual Behavior

The translation status is incorrect

Additional Information

Screenshot 2022-10-24 at 16-45-23 Integreat Redaktionssystem

@timobrembeck timobrembeck added 🐛 bug Something isn't working 🍼 good first issue Good for newcomers ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels Oct 24, 2022
@timobrembeck timobrembeck added this to the 22Q4 milestone Oct 24, 2022
@JoeyStk JoeyStk self-assigned this Nov 10, 2022
This was referenced Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 good first issue Good for newcomers 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants