Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove short description field from POI model #1807

Closed
ulliholtgrave opened this issue Oct 26, 2022 · 3 comments · Fixed by #1817
Closed

Remove short description field from POI model #1807

ulliholtgrave opened this issue Oct 26, 2022 · 3 comments · Fixed by #1817
Assignees
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@ulliholtgrave
Copy link
Member

Motivation

The service team requested to remove the short description field from the POI model as the app doesn't use it.

Proposed Solution

Remove the "short description" field from:

  • POIForm
  • POI model
  • POI-API
@ulliholtgrave ulliholtgrave added 💡 feature New feature or request 🍼 good first issue Good for newcomers ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h labels Oct 26, 2022
@ulliholtgrave ulliholtgrave added this to the 22Q4 milestone Oct 26, 2022
@timobrembeck
Copy link
Member

Can we use the information which is already entered in this field as meta-information?
In other words, instead of removing the field, can we also rename it to meta_description and solve issue #522 partially with it?

@ulliholtgrave
Copy link
Member Author

Yeah, I think that this is a good idea 👍 However, I would then move the field within the form. Right now it's pretty present next to the title and maybe we could think of some kind of "SEO section" beneath the whole content section.

@timobrembeck
Copy link
Member

However, I would then move the field within the form. Right now it's pretty present next to the title and maybe we could think of some kind of "SEO section" beneath the whole content section.

Sounds good! And make the field optional, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants