Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape text sent to Textlab API #1808

Merged
merged 1 commit into from Oct 26, 2022
Merged

Conversation

timobrembeck
Copy link
Member

Short description

Unescape text sent to Textlab API

Proposed changes

  • Call unescape() on the text before sending it to the textlab api
  • Make trailing slash of API setting optional

Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner October 26, 2022 12:42
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Oct 26, 2022

Code Climate has analyzed commit 71b50c1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 33.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@timobrembeck timobrembeck merged commit 79aa6db into develop Oct 26, 2022
@timobrembeck timobrembeck deleted the enhancement/textlab branch October 26, 2022 13:03
@ulliholtgrave ulliholtgrave mentioned this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants