Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for FirebaseApiClient #1824

Closed
Tracked by #765
Gaston69 opened this issue Nov 3, 2022 · 0 comments · Fixed by #1825
Closed
Tracked by #765

Tests for FirebaseApiClient #1824

Gaston69 opened this issue Nov 3, 2022 · 0 comments · Fixed by #1825
Assignees
@Gaston69
Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Milestone
22Q4

Comments

@Gaston69
Copy link
Contributor

Gaston69 commented Nov 3, 2022

Motivation

The firebase push-notification-sender functions have no unit-tests, that ensure the correct function

Proposed Solution

writing tests that use a local firebase-emulator
@Gaston69 Gaston69 added 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 🔨 enhancement This improves an existing feature 😅 effort: medium Should be doable in <12h and removed 💡 feature New feature or request labels Nov 3, 2022
@Gaston69 Gaston69 mentioned this issue Nov 3, 2022
Merged
@timobrembeck timobrembeck mentioned this issue Nov 3, 2022
Open
33 tasks
@Gaston69 Gaston69 self-assigned this Nov 8, 2022
@Gaston69 Gaston69 linked a pull request Nov 8, 2022 that will close this issue
Tests for Firebase API #1839
Closed
@Gaston69 Gaston69 mentioned this issue Nov 8, 2022
Closed
@timobrembeck timobrembeck added this to the 22Q4 milestone Nov 9, 2022
@timobrembeck timobrembeck changed the title Tests for api_client_firebase Tests for FirebaseApiClient Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gaston69 Gaston69

Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Projects
None yet
Milestone
22Q4
2 participants
@timobrembeck @Gaston69