Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint about icon aspect ratio to POI form #1890

Merged
merged 1 commit into from Nov 23, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Add hint about ideal aspect ratio to POI form
See https://issues.tuerantuer.org/browse/IGAPP-920 for reference.

Proposed changes

  • Add hint about aspect ratio to POI form

Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner November 22, 2022 21:33
@timobrembeck timobrembeck changed the title Add hint about aspect ratio to POI form Add hint about icon aspect ratio to POI form Nov 22, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit 5640d90 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@timobrembeck timobrembeck merged commit 521be6e into develop Nov 23, 2022
@timobrembeck timobrembeck deleted the enhancement/poi-form-icon branch November 23, 2022 12:58
@timobrembeck timobrembeck mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants