Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude users without view_page permission for page-specific permissions #1900

Closed
timobrembeck opened this issue Nov 25, 2022 · 0 comments · Fixed by #1901
Closed

Exclude users without view_page permission for page-specific permissions #1900

timobrembeck opened this issue Nov 25, 2022 · 0 comments · Fixed by #1901
Assignees
Labels
🔨 enhancement This improves an existing feature ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@timobrembeck
Copy link
Member

Describe the Bug

At the moment, users, who don't have the permission to view the page tree at all can be granted the permission to edit specific pages. This does not make sense, since the users are not allowed to open the page form if they are not allowed to view pages.

Steps to Reproduce

  1. Enable page-specific permissions
  2. See e.g. event manager role in selection field

Expected Behavior

Users without the permission to view pages should be excluded from the possible choices

Actual Behavior

They are shown

Additional Information

Together with #1494, this hopefully makes the feature usable.
Maybe we should also enable page-specific permissions in the test data as well, so we notice potential problems earlier.

@timobrembeck timobrembeck added ❗ prio: medium Should be scheduled in the forseeable future. 🔨 enhancement This improves an existing feature ☺️ effort: low Should be doable in <4h labels Nov 25, 2022
@timobrembeck timobrembeck added this to the 22Q4 milestone Nov 25, 2022
@MizukiTemma MizukiTemma self-assigned this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement This improves an existing feature ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants