Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link escape in message in imprint form #1906

Closed
MizukiTemma opened this issue Nov 28, 2022 · 3 comments · Fixed by #1976
Closed

Fix link escape in message in imprint form #1906

MizukiTemma opened this issue Nov 28, 2022 · 3 comments · Fixed by #1976
Assignees
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Nov 28, 2022

Describe the Bug

A message will be shown in the imprint form if the standard language is currently duplicated for the given language and it contains a link to the version which is shown in the app. Thogh the link is not well escaped and the tag is directly shown.

Steps to Reproduce

  1. Go to Imprint in the menu.
  2. Click on the tab of a translation for which the default language is duplicated.
  3. See the message on the top of the form.

Expected Behavior

A link is shown.

Actual Behavior

A tag is shown.

Additional Information

not_well_escaped_link

The link target is probably also incorrect. It doesn't make sense that revision 1 is shown while there is no version yet for the language. (See the screen shot. No version has been yet created (and therefore the default language is duplicated) for Easy German but the message says version 1 of Easy German is shown in the app.)
Edit: This is #1813

@MizukiTemma MizukiTemma added the 🐛 bug Something isn't working label Nov 28, 2022
@MizukiTemma MizukiTemma added this to the 22Q4 milestone Nov 28, 2022
@timobrembeck timobrembeck added ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h labels Nov 28, 2022
@seluianova
Copy link
Contributor

It doesn't make sense that revision 1 is shown while there is no version yet for the language

So, if there is no version yet, I would guess we don't need this message at all. Do we?

Also, there is no such message for other entities (pages, pois, events).
Why do we have it for imprint only?

@seluianova seluianova self-assigned this Nov 30, 2022
@timobrembeck
Copy link
Member

However if I understand it correctly, it is not reachable. Because when the last page translation is DRAFT, all previous are also set to DRAFT. If this is correct, we should probably also remove this block of code from page view to avoid confusion

There are two exceptions to this rule:

  1. When there are autosaves or in-review pages, not the newest version is shown the app, but only the newest public version.
  2. When old revisions are restored as draft from the revision slider, only the restored version is a draft and the previous version will be still published.

We still have it on our plate to create a better UI for these kind of workflows, so in theory it should be a bit easier to work on a new state while still delivering the old state in the apps, but I'm not sure whether there is even an open ticket for it.

@seluianova
Copy link
Contributor

@timoludwig now I could reproduce it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants