Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of page permission button #1912

Merged
merged 3 commits into from Nov 30, 2022
Merged

Conversation

timobrembeck
Copy link
Member

Short description

Fix alignment of page permission button

Proposed changes

  • Enable page-specific permissions in test data
  • Fix alignment of page permission button

Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner November 29, 2022 13:44
@codeclimate
Copy link

codeclimate bot commented Nov 29, 2022

Code Climate has analyzed commit d651534 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.8% (0.0% change).

View more on Code Climate.

Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and it's a good idea to aktivate the page-specific permission in test data as default 😃

Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timobrembeck timobrembeck merged commit a17ede5 into develop Nov 30, 2022
@timobrembeck timobrembeck deleted the bugfix/page-permissions branch November 30, 2022 14:42
@timobrembeck timobrembeck mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants