Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide page link edit button for observers wihout change/edit permission #1969

Closed
MizukiTemma opened this issue Dec 13, 2022 · 0 comments · Fixed by #1987
Closed

Hide page link edit button for observers wihout change/edit permission #1969

MizukiTemma opened this issue Dec 13, 2022 · 0 comments · Fixed by #1987
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@MizukiTemma
Copy link
Member

Describe the Bug

An edit-button (pen icon) next to the page link is shown in the page form for observer users, even when they do not have permission to edit the page.
Since it does not make sense to show this icon while the user is not allowed to change/edit the page, it should be hidden when changing/editing permission is not granted.

Steps to Reproduce

  1. Log in as observer.
  2. Go to a page for which this observer does not have permission to change/edit.
  3. See the edit-icon is shown.

Expected Behavior

The edit icon is not shown if the observer user cannot change/edit the page.

Actual Behavior

The edit icon is shown even if they cannot change/edit the page.

Additional Information

In the pages which are shared with the observer (for exmaple by page-specific permission) the button should appear.

Traceback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant