Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to select 2FA methods if they setup more than one #1974

Closed
ulliholtgrave opened this issue Dec 15, 2022 · 0 comments · Fixed by #2257
Closed

Allow user to select 2FA methods if they setup more than one #1974

ulliholtgrave opened this issue Dec 15, 2022 · 0 comments · Fixed by #2257
Assignees
@ulliholtgrave
Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Milestone
23Q3

Comments

@ulliholtgrave
Copy link
Member

Motivation

Right now user are forced to use FIDO2 even if they enabled TOTP, because we are checking FIDO2 first and redirect the user to the MFA authentication afterwards. The check for TOTP gets never reached if FIDO2 keys exist for the user.

Proposed Solution

We should provide an link for the user to choose TOTP as a backup if it is activated.
@ulliholtgrave ulliholtgrave added 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. 😅 effort: medium Should be doable in <12h labels Dec 15, 2022
@ulliholtgrave ulliholtgrave added this to the 23Q1 milestone Dec 15, 2022
@ulliholtgrave ulliholtgrave changed the title Allow user to select 2FA methods if they setup more then one Allow user to select 2FA methods if they setup more than one Feb 17, 2023
@ulliholtgrave ulliholtgrave added ⁉️ prio: low Not urgent, can be resolved in the distant future. and removed ❗ prio: medium Should be scheduled in the forseeable future. labels Feb 17, 2023
@ulliholtgrave ulliholtgrave modified the milestones: 23Q1, 23Q2 Feb 18, 2023
@ulliholtgrave ulliholtgrave mentioned this issue May 2, 2023
Merged
@ulliholtgrave ulliholtgrave self-assigned this May 6, 2023
@timobrembeck timobrembeck modified the milestones: 23Q2, 23Q3 Jul 2, 2023
@ulliholtgrave ulliholtgrave mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulliholtgrave ulliholtgrave

Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Projects
None yet
Milestone
23Q3
Development

Successfully merging a pull request may close this issue.

Refactor MFA setup and make fallback method available digitalfabrik/integreat-cms
2 participants
@ulliholtgrave @timobrembeck