Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links found in archived pages after cloning region #2012

Closed
Tracked by #1704
timobrembeck opened this issue Jan 17, 2023 · 1 comment · Fixed by #2089
Closed
Tracked by #1704

Links found in archived pages after cloning region #2012

timobrembeck opened this issue Jan 17, 2023 · 1 comment · Fixed by #2089
Assignees
@seluianova
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working 😅 effort: medium Should be doable in <12h
Milestone
23Q1

Comments

@timobrembeck
Copy link
Member

Describe the Bug

When a region is cloned, the link checker of the new region contains links in archived pages, even if these links were not present in the source region.

Steps to Reproduce

  1. Create region with archived pages that contain links
  2. See link checker of that region which does not contain the links in archived pages
  3. Clone that region to a new region
  4. See link checker of the new region which now contains the links in archived pages

Expected Behavior

The cloned region should also exclude links in archived pages

Actual Behavior

The cloned region has links in archived pages

Additional Information
@timobrembeck timobrembeck added 🐛 bug Something isn't working ‼️ prio: high Needs to be resolved ASAP. 😅 effort: medium Should be doable in <12h labels Jan 17, 2023
@timobrembeck timobrembeck added this to the 23Q1 milestone Jan 17, 2023
@timobrembeck timobrembeck mentioned this issue Jan 17, 2023
Open
47 tasks
@JoeyStk
Copy link
Contributor

JoeyStk commented Feb 17, 2023

Workaround: Archived pages are not supposed to be cloned

@seluianova seluianova self-assigned this Feb 20, 2023
@seluianova seluianova linked a pull request Feb 20, 2023 that will close this issue
Exclude archived pages when cloning a region #2089
Merged
@seluianova seluianova mentioned this issue Feb 20, 2023
Merged
@timobrembeck timobrembeck mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seluianova seluianova

Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working 😅 effort: medium Should be doable in <12h
Projects
None yet
Milestone
23Q1
Development

Successfully merging a pull request may close this issue.

Exclude archived pages when cloning a region digitalfabrik/integreat-cms
3 participants
@timobrembeck @JoeyStk @seluianova