Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check links in inactive languages #2054

Closed
Tracked by #1704
timobrembeck opened this issue Feb 6, 2023 · 0 comments · Fixed by #2251
Closed
Tracked by #1704

Do not check links in inactive languages #2054

timobrembeck opened this issue Feb 6, 2023 · 0 comments · Fixed by #2251
Assignees
@MizukiTemma
Labels
💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. 😅 effort: medium Should be doable in <12h
Milestone
23Q2

Comments

@timobrembeck
Copy link
Member

Motivation

At the moment, the link checker is active for all languages of a region, independent from their status.

Proposed Solution

Ignore inactive languages in the link checker (invisible languages are still ok I think):

  • Add a new object_filter (see docs) for all link lists
  • Whenever the active field of a language tree node is toggled from True to False, delete all link objects which belong to translations in that language
  • Whenever the active field of a language tree node is toggled from False to True, trigger the link scan for all translations in that language
@timobrembeck timobrembeck added 💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h labels Feb 6, 2023
@timobrembeck timobrembeck added this to the 23Q2 milestone Feb 6, 2023
@timobrembeck timobrembeck mentioned this issue Feb 8, 2023
Open
47 tasks
@JoeyStk JoeyStk added ❗ prio: medium Should be scheduled in the forseeable future. and removed ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Mar 6, 2023
@MizukiTemma MizukiTemma self-assigned this Apr 25, 2023
@MizukiTemma MizukiTemma mentioned this issue Apr 26, 2023
Merged
@timobrembeck timobrembeck mentioned this issue Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MizukiTemma MizukiTemma

Labels
💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. 😅 effort: medium Should be doable in <12h
Projects
None yet
Milestone
23Q2
Development

Successfully merging a pull request may close this issue.

Do not check links in inactive languages digitalfabrik/integreat-cms
3 participants
@timobrembeck @JoeyStk @MizukiTemma