Check result of prospective merge in CircleCI #2060
Labels
💡 feature
New feature or request
❗ prio: medium
Should be scheduled in the forseeable future.
😱 effort: high
Big change, which requires >12h
Milestone
Motivation
At the moment, the CircleCI tests only check the state of a specific branch. It does not check whether the result of a merged PR is valid as well. This is bad because sometimes, there is no actual file conflicts which git detects, but an implicit conflict of e.g. the migration files, or side-effects of tests etc.
Proposed Solution
Add a new job to circleci to merge the changes into the develop branch (locally on the CI server without pushing yet) and then re-run all other jobs to make sure that everything works both on the branch and also after merging.
Unfortunately, there is no straight forward way for doing this in CircleCI, see e.g. this discussions:
Alternatives
We could also require PRs to be up to date with the default branch before they can be merged. This would add a little bit of overhead for PR authors and require even more rebases than right now.
The text was updated successfully, but these errors were encountered: