Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary buttons look exactly like disabled buttons #2170

Closed
timobrembeck opened this issue Mar 27, 2023 · 9 comments · Fixed by #2253
Closed

Secondary buttons look exactly like disabled buttons #2170

timobrembeck opened this issue Mar 27, 2023 · 9 comments · Fixed by #2253
Assignees
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@timobrembeck
Copy link
Member

Describe the Bug

The "preview" and "save as draft" buttons are grey to separate them from the "publish/update" buttons.
However, this has the disadvantage that they look exactly like disabled buttons.

Expected Behavior

It's ok to separate them from the "main" button by a separate color, but grey is a bad choice

Actual Behavior

They look disabled

Additional Information

Screenshot 2023-03-27 at 14-06-20 Integreat Editorial System

For the "preview" button I think it could make sense to use the same color as for filters (since the meaning of the light blue could be described as "something that has no immediate influence on the state of the system"):
Screenshot 2023-03-27 at 14-07-07 Integreat Editorial System

For "draft" this isn't ideal however, since it changes the database and the click itself cannot be reversed.

@timobrembeck timobrembeck added 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. 🌈 ui-ux Issues that requires an UI/UX perspective. ☺️ effort: low Should be doable in <4h labels Mar 27, 2023
@timobrembeck timobrembeck added this to the Backlog milestone Mar 27, 2023
@seluianova
Copy link
Contributor

seluianova commented Mar 27, 2023

As an option - make the disabled button lighter + gray text?
image

Or we could reduce the opacity for disabled buttons while keeping the original color:
image

But then the "Show filters" button should be gray, so it doesn't look disabled.

@timobrembeck
Copy link
Member Author

@digitalfabrik/ui-ux-team do you have input on this?

@JoeyStk
Copy link
Contributor

JoeyStk commented Apr 17, 2023

I know my opinion isn't really asked here, but I like outline and ghost-buttons as secondary buttons
grafik. I think if we only have two levels of hierarchy I would go for outline buttons, if we have more than two I would go for ghost buttons

@timobrembeck
Copy link
Member Author

@JoeyStk Cool idea!
If we don't get a response by the UI/UX team, I think we can go ahead and implement this guideline:

        &.btn-ghost {
            @apply bg-blue-100 text-blue-500;
            &:hover {
                @apply bg-blue-200;
            }
        }
        &.btn-outline {
            @apply border-2 border-blue-500 text-blue-500 bg-white;
            &:hover {
                @apply bg-blue-100;
            }
        }

Screenshot 2023-04-17 at 20-11-46 Integreat Editorial System

@hauf-toni
Copy link

@JoeyStk Cool idea! If we don't get a response by the UI/UX team, I think we can go ahead and implement this guideline:

        &.btn-ghost {
            @apply bg-blue-100 text-blue-500;
            &:hover {
                @apply bg-blue-200;
            }
        }
        &.btn-outline {
            @apply border-2 border-blue-500 text-blue-500 bg-white;
            &:hover {
                @apply bg-blue-100;
            }
        }

Screenshot 2023-04-17 at 20-11-46 Integreat Editorial System

@JoeyStk @timoludwig from an ui/ux perspective the outlined button is the best choice here, as it complies with best practice standards, see Google Material components ("Use an outlined button for actions that need attention but aren’t the primary action[ ...]"
If you tag @digitalfabrik/ui-ux-team , you can also tag @hauf-toni , this will also point me to the thread via mail. I appreciate that, thank you :)

@timobrembeck
Copy link
Member Author

@hauf-toni ah sorry, I thought mentioning the team had the same effect, but ok I will use the individual username in the future.
Would be cool though if we could somehow fix the notification settings, since the team name is easier to remember...

@JoeyStk
Copy link
Contributor

JoeyStk commented Apr 24, 2023

We discussed this issue in our bi-weekly-meeting between service team, UI/UX team and our team. We came up with the following solution:

  • Secondary buttons should become outline buttons (as seen in the screenshot above)
  • Buttons that fulfill a different purpose than the rest of the buttons on the page should become ghost buttons (as seen for preview in the screenshot above)
  • Disabled buttons should remain grey, but if possible a less saturated grey tone (for example #A1A1AA)
  • Add styleguide / documentation for this so future developers have a guidance when making the choice

With this information the issue should be ready for implementation and therefore was moved to the current milestone with a low priority

@JoeyStk JoeyStk removed the 🌈 ui-ux Issues that requires an UI/UX perspective. label Apr 24, 2023
@JoeyStk JoeyStk modified the milestones: Backlog, 23Q2 Apr 24, 2023
@timobrembeck
Copy link
Member Author

@JoeyStk Sounds good, thanks for clarification!

Disabled buttons should remain grey, but if possible a less saturated grey tone (for example #A1A1AA)

I would suggest to stick with our existing color palette, so ideally we could choose a lighter grey from https://tailwindcss.com/docs/customizing-colors
(At the moment, it is gray-500/#6b7280, so we could move to gray-400/#9ca3af)

@JoeyStk
Copy link
Contributor

JoeyStk commented Apr 24, 2023

Yes, sounds reasonable. @hauf-toni was referring to the Integreat color scheme, but also said we were free in making the final decision of what works best for us. So let's try gray-400 then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants