Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide inactive languages in MT form #2178

Merged
merged 1 commit into from Mar 28, 2023
Merged

Hide inactive languages in MT form #2178

merged 1 commit into from Mar 28, 2023

Conversation

charludo
Copy link
Contributor

Short description

Inactive languages should be hidden in the MT form.

Proposed changes

  • hide it.

Side effects

  • none

Pull Request Review Guidelines

@charludo charludo requested a review from a team as a code owner March 28, 2023 10:47
@codeclimate
Copy link

codeclimate bot commented Mar 28, 2023 •
edited

Code Climate has analyzed commit 3f13365 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.0% (0.0% change).

View more on Code Climate.

JoeyStk
JoeyStk approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉
Do we need a release note for this?

timobrembeck
timobrembeck approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Do we need a release note for this?

I'd say yes, why not. It's a change that's noticeable to the content creators.

@charludo
Copy link
Contributor Author

I'd say yes, why not. It's a change that's noticeable to the content creators.

Do I need to create an issue for this then?

@timobrembeck
Copy link
Member

Do I need to create an issue for this then?

No, just reference this PR #2178 as issue number

@charludo charludo force-pushed the fix/no-mt-for-inactive-languages branch from 3dfd043 to 3f13365 Compare March 28, 2023 12:07
@charludo charludo merged commit ed4f1d2 into develop Mar 28, 2023
5 checks passed
@charludo charludo deleted the fix/no-mt-for-inactive-languages branch March 28, 2023 13:32
@ulliholtgrave ulliholtgrave mentioned this pull request Apr 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timobrembeck timobrembeck timobrembeck approved these changes

@JoeyStk JoeyStk JoeyStk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charludo @timobrembeck @JoeyStk