Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to replace malformed mailto: or tel: links #2198

Closed
Tracked by #1704
timobrembeck opened this issue Apr 4, 2023 · 0 comments · Fixed by #2199
Closed
Tracked by #1704

Unable to replace malformed mailto: or tel: links #2198

timobrembeck opened this issue Apr 4, 2023 · 0 comments · Fixed by #2199
Assignees
@timobrembeck
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Milestone
23Q2

Comments

@timobrembeck
Copy link
Member

Describe the Bug

Email and tel links are hidden in the broken link checker, so normally they do not show up.
However, when they are malformed in any way, e.g. a link was created https://tel:12345, it's impossible to fix this problem in the broken link checker, because it only accepts valid URLs, not valid email or tel links.

Steps to Reproduce

  1. Create malformed tel link in content
  2. Try to fix problem in broken link checker
  3. See validation error

Expected Behavior

It should be possible to replace incorrect links, even if they use mailto: or tel: targets.

Actual Behavior

Only links with http:///https:// can be replaced

Additional Information
@timobrembeck timobrembeck added 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h labels Apr 4, 2023
@timobrembeck timobrembeck added this to the 23Q2 milestone Apr 4, 2023
@timobrembeck timobrembeck self-assigned this Apr 4, 2023
This was referenced Apr 4, 2023
Open
Merged
@timobrembeck timobrembeck mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timobrembeck timobrembeck

Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Projects
None yet
Milestone
23Q2
Development

Successfully merging a pull request may close this issue.

Add emails and phone link checker digitalfabrik/integreat-cms
1 participant
@timobrembeck