Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add social media headers endpoint #2084

Open
Tracked by #2659
svenseeberg opened this issue Feb 18, 2023 · 2 comments · May be fixed by #2391
Open
Tracked by #2659

API: Add social media headers endpoint #2084

svenseeberg opened this issue Feb 18, 2023 · 2 comments · May be fixed by #2391
Assignees
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working 💡 feature New feature or request
Milestone

Comments

@svenseeberg
Copy link
Member

Motivation

We currently have a quick and dirty solution for rendering social media headers (https://git.tuerantuer.org/Integreat/social-media-meta-tags/src/branch/master/meta.php). This should be replaced by a long term solution within the CMS.

Proposed Solution

We probably need to keep the part with the Nginx Server Side Includes. However, we should move the functionality of the PHP script directly into the CMS and also support events, locations, etc.

Alternatives

Implement the full URL pattern and API functionality in our hacky PHP script. :-(

Additional Context

Design Requirements

@svenseeberg svenseeberg added the 💡 feature New feature or request label Feb 18, 2023
@svenseeberg svenseeberg added this to the 23Q3 milestone Feb 18, 2023
@sarahsporck
Copy link
Contributor

I think this really has a lot of potential. It is always better to render SEO tags on the initial render. Therefore, directly injecting them on the server makes lots of sense and is also how SEO is implemented traditionally. Currently, it feels like a mix between the responsibilities in the nginx and the frontend.

Minimum requirements

As a minimum requirement <title>, <description> tags, the Open Graph protocol tags and twitter card tags should be present.

Additions

We could also inject JSON-LD for events or breadcrumbs in the backend, which we are currently implementing in the frontend.

Problems

I am not sure if all sites in the frontend are also present

Additional context

For more context check out IGAPP-100

Medium:

• Facebook: Beitrag teilen, Sharing-Text als Beitragstext
• WhatsApp: Auswahl öffnet sich, an wen es geschickt werden soll, Sharing-Text als Beitragstext
• Twitter: Beitrag teilen, Sharing-Text als Beitragstext
• Mail: neue E-Mail zum Verfassen öffnet sich, Sharing-Text als E-Mail-Text, Betreff: „Integreat Leseempfehlung: Titel des Beitrags“ (Betreff-Text in die jeweilig genutzte Sprache in der Web App übersetzen)
• PDF: Format öffnet sich

Ansicht:

Anzeigebild (vorhandenes Bild aus der Web App (wenn kein Bild vorhanden ist, dann vom Promo Team ausgewähltes Bild benutzen), Titel, Anfang vom Text (Teaser)

Sprache:

Anzeige in der jeweilig genutzten Sprache

Sharing-Text:

„Gerade in der #IntegreatApp entdeckt. Was hältst du davon?“
• Auch in die jeweilige Sprache übersetzen, die für den Integreat Inhalt genutzt wurde

@ulliholtgrave ulliholtgrave modified the milestones: 23Q3, 23Q4 Jul 17, 2023
@svenseeberg svenseeberg added the ‼️ prio: high Needs to be resolved ASAP. label Aug 1, 2023
@svenseeberg svenseeberg self-assigned this Aug 1, 2023
@svenseeberg svenseeberg modified the milestones: 23Q4, 23Q3 Aug 1, 2023
@svenseeberg svenseeberg added the 🐛 bug Something isn't working label Aug 7, 2023
@svenseeberg
Copy link
Member Author

svenseeberg commented Aug 7, 2023

I added a bug label because there is a bug in our current implementation outside this CMS. The current solution does not work for HTTP/2 connections.

@svenseeberg svenseeberg linked a pull request Aug 7, 2023 that will close this issue
@svenseeberg svenseeberg modified the milestones: 23Q3, 23Q4 Oct 4, 2023
@osmers osmers added ❗ prio: medium Should be scheduled in the forseeable future. and removed ‼️ prio: high Needs to be resolved ASAP. labels Oct 4, 2023
svenseeberg added a commit that referenced this issue Oct 12, 2023
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
svenseeberg added a commit that referenced this issue Oct 12, 2023
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
svenseeberg added a commit that referenced this issue Oct 12, 2023
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
svenseeberg added a commit that referenced this issue Oct 12, 2023
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
svenseeberg added a commit that referenced this issue Oct 12, 2023
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
sarahsporck pushed a commit that referenced this issue Dec 7, 2023
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
@timobrembeck timobrembeck modified the milestones: 23Q4, 24Q1 Jan 10, 2024
sarahsporck pushed a commit that referenced this issue Jan 31, 2024
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
sarahsporck pushed a commit that referenced this issue Feb 20, 2024
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
david-venhoff pushed a commit that referenced this issue Mar 25, 2024
Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
@JoeyStk JoeyStk added ‼️ prio: high Needs to be resolved ASAP. and removed ❗ prio: medium Should be scheduled in the forseeable future. labels Apr 3, 2024
@JoeyStk JoeyStk modified the milestones: 24Q1, 24Q2 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working 💡 feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants