Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the date display of the German locale #2446

Merged
merged 1 commit into from Oct 10, 2023

Conversation

timobrembeck
Copy link
Member

Short description

Improve the date display of the German locale.
See docs: https://docs.djangoproject.com/en/3.2/ref/settings/#format-module-path

Proposed changes

  • Instead of 09. Oktober 2023 22:15 write 09. Oktober 2023 um 22:15 Uhr

Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner October 9, 2023 23:09
@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023

Code Climate has analyzed commit 07d4076 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.5% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in firefox 👍🏼

integreat_cms/core/formats/de/formats.py Show resolved Hide resolved
Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timobrembeck timobrembeck merged commit 349330e into develop Oct 10, 2023
5 checks passed
@timobrembeck timobrembeck deleted the feature/date-formats branch October 10, 2023 14:45
@timobrembeck timobrembeck mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants