Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved changes indicator #2477

Open
PeterNerlich opened this issue Oct 23, 2023 · 8 comments · May be fixed by #2476
Open

Unsaved changes indicator #2477

PeterNerlich opened this issue Oct 23, 2023 · 8 comments · May be fixed by #2476
Assignees
@PeterNerlich
Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Milestone
24Q2

Comments

@PeterNerlich
Copy link
Contributor

Motivation

As a user editing e.g. a page, I want to know whether I have unsaved changes, or notice when an autosave is successful.
This should result in slightly higher perceived reliability of the system through transparency and predictability.

Proposed Solution

Add a bullet to the document title whenever the form is different from the most recently saved state.

Alternatives

  • Add a banner to the top of the page once changes have been saved
    Might get annoying, especially if it changes the layout / scroll position relative to the focused element. Very verbose compared to the minor role this indicator is supposed to achieve.
  • Add an indicator to the tinymce editor
    Might be relatively complex

The proposed solution is not better than these alternatives. But it requires way less effort and is a good starting point.

User Story

As an editor, I want to know whether I have unsaved changes, or notice when an autosave is successful, so that I have a higher trust in the system.
@PeterNerlich PeterNerlich added 💡 feature New feature or request javascript 😅 effort: medium Should be doable in <12h labels Oct 23, 2023
@PeterNerlich PeterNerlich linked a pull request Oct 23, 2023 that will close this issue
Open
@PeterNerlich PeterNerlich self-assigned this Oct 23, 2023
@osmers
Copy link

osmers commented Oct 23, 2023

We are already introducing the new auto saved message, right? Wouldn't it then make sense to simply erase that message if there are unsaved changes? To show that the current version is not auto-saved yet?

@PeterNerlich
Copy link
Contributor Author

PeterNerlich commented Oct 23, 2023 •
edited

@osmers I'm not up to date regarding this, do you have an issue/PR id for me?

Edit: It's #2431, I'm blind

@MizukiTemma
Copy link
Member

I haven't checked your PR for this issue, but you mean you need this for #2401 , right?

@PeterNerlich
Copy link
Contributor Author

@MizukiTemma No, the other way around. #2476 builds on (=contains the commit for) #2401, so after #2401 is merged, I would like this to be considered to be merged.

@osmers
Copy link

osmers commented Oct 24, 2023

@PeterNerlich yeah, #2431 is the one I meant. Does your last comment then mean, that this issue will be closed? Though we can still discuss the "notice when I have unsaved changes" bit of your issue.

@PeterNerlich
Copy link
Contributor Author

PeterNerlich commented Oct 24, 2023 •
edited

Does your last comment then mean, that this issue will be closed?

I created this issue mostly because I need a valid issue ID in order to add a release note to #2476 as per our new_release_note.sh tool. If that PR is merged, this issue will be closed automatically as it is listed as addressing this issue.
The implemented functionality relevant to this issue kind of emerged as a byproduct of the rest of the changes I did. I included it because it was like 4 lines of code and felt really good to me. Whether we decide to use these, merge them with #2431 or reject them for it, is all fine with me. I have opinions on UX, but no strong feelings for this implementation in particular.
@osmers

@timobrembeck timobrembeck added this to the 23Q4 milestone Oct 24, 2023
@timobrembeck
Copy link
Member

I created this issue mostly because I need a valid issue ID in order to add a release note to #2476 as per our new_release_note.sh tool.

Nothing wrong with creating an issue for this, but just fyi: The tool works well with PR numbers instead of issue, since GitHub correctly redirects these URLs:

https://github.com/digitalfabrik/integreat-cms/issues/2476 is redirected to https://github.com/digitalfabrik/integreat-cms/pull/2476.

@timobrembeck timobrembeck modified the milestones: 23Q4, 24Q1 Jan 10, 2024
@JoeyStk JoeyStk added the ⁉️ prio: low Not urgent, can be resolved in the distant future. label Apr 3, 2024
@JoeyStk JoeyStk modified the milestones: 24Q1, 24Q2 Apr 3, 2024
@dkehne
Copy link

dkehne commented May 25, 2024

Any more need to discuss here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterNerlich PeterNerlich

Labels
💡 feature New feature or request ⁉️ prio: low Not urgent, can be resolved in the distant future. 😅 effort: medium Should be doable in <12h
Projects
None yet
Milestone
24Q2
Development

Successfully merging a pull request may close this issue.

Robust changed content detection digitalfabrik/integreat-cms
6 participants
@dkehne @PeterNerlich @timobrembeck @osmers @JoeyStk @MizukiTemma