Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto create/update link texts to Integreat content #1878

Open
Tracked by #1704
svenseeberg opened this issue Nov 18, 2022 · 2 comments · May be fixed by #2530
Open
Tracked by #1704

Auto create/update link texts to Integreat content #1878

svenseeberg opened this issue Nov 18, 2022 · 2 comments · May be fixed by #2530
Assignees
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😱 effort: high Big change, which requires >12h
Milestone

Comments

@svenseeberg
Copy link
Member

svenseeberg commented Nov 18, 2022

Motivation

With the introduction of our location feature, we're more and more often referencing internal content. However, it is still a relatively high effort to create a new new link, for example to a location. First, a text has to be created. Then the text has to be selected and the link has to be inserted. If the title of the location changes in the structured database, the link description is not updated.

Proposed Solution

When inserting a link without having a text selected, automatically create a useful text from the link target. This is already happening for page titles. If it is a location, it should insert the title and address, including icons.

Also, and that is the most interesting part, add an additional HTML attribute that marks the link text as being automatically created. The attribute could be invented, for example integreat-auto-content=1. We can then use the Django linkcheck database to update the link text whenever we update the location, page title, etc. That means when updating a location, for example, we retrieve all pages that link to this location. We then iterate over all a tags with links and our attribute and then update the link text. This could probably be a part of our abstract content translation model save method.

It should be made obvious to the user how to use this. When inserting a link, we already have a dialog for selecting an internal content to link to. This dialog needs something like a check box "automatically update link description". This check box should be checked when having no text selected. When having a text selected, the checkbox should be unchecked.

Alternatives

None. It's a really cool killer feature 🚀

Additional Context

It would be cool if translations are fixed automatically. That means if the location is translated into arabic, but the link in a page is still to the german location, this should be fixed automatically.

Design Requirements

We should probably get some good drafts for the dialog boxes. And we also have to improve the "change link" box.

Also we need nice defaults for rendering locations and maybe also events.

@svenseeberg svenseeberg added 💡 feature New feature or request 😅 effort: medium Should be doable in <12h labels Nov 18, 2022
@svenseeberg svenseeberg added this to the 23Q1 milestone Nov 18, 2022
@svenseeberg svenseeberg added the ⁉️ prio: low Not urgent, can be resolved in the distant future. label Nov 19, 2022
@ulliholtgrave ulliholtgrave added 🆘 prio: urgent Needs to be resolved now(?) and removed ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Feb 17, 2023
@svenseeberg svenseeberg added ‼️ prio: high Needs to be resolved ASAP. and removed 🆘 prio: urgent Needs to be resolved now(?) labels Feb 17, 2023
@ulliholtgrave ulliholtgrave added ❗ prio: medium Should be scheduled in the forseeable future. and removed ‼️ prio: high Needs to be resolved ASAP. labels Feb 17, 2023
@timobrembeck timobrembeck modified the milestones: 23Q1, 23Q2 Mar 17, 2023
@timobrembeck timobrembeck modified the milestones: 23Q2, 23Q3 Jul 2, 2023
@ulliholtgrave ulliholtgrave added 😱 effort: high Big change, which requires >12h and removed 😅 effort: medium Should be doable in <12h labels Jul 17, 2023
@ulliholtgrave ulliholtgrave modified the milestones: 23Q3, 23Q4 Jul 17, 2023
@david-venhoff david-venhoff self-assigned this Oct 23, 2023
@david-venhoff
Copy link
Member

If it is a location, it should insert the title and address, including icons.

Shouldn't stuff like this ideally be implemented in the frontend? That way, they could decide how to display all the relevent poi information and we would only have to provide some metadata with the link

@timobrembeck
Copy link
Member

Shouldn't stuff like this ideally be implemented in the frontend? That way, they could decide how to display all the relevent poi information and we would only have to provide some metadata with the link

I did not find our previous discussion about this topic, but I think I remember we rejected the idea of having something like an intermediary html syntax that needs to be rendered differently by the app.

@david-venhoff david-venhoff linked a pull request Nov 6, 2023 that will close this issue
@timobrembeck timobrembeck modified the milestones: 23Q4, 24Q1 Jan 10, 2024
@JoeyStk JoeyStk added ‼️ prio: high Needs to be resolved ASAP. and removed ❗ prio: medium Should be scheduled in the forseeable future. labels Apr 3, 2024
@JoeyStk JoeyStk modified the milestones: 24Q1, 24Q2 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😱 effort: high Big change, which requires >12h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants