Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring test coverage to 82,5 % #2582

Closed
Tracked by #765
MizukiTemma opened this issue Dec 5, 2023 · 10 comments · Fixed by #2620 or #2669
Closed
Tracked by #765

Bring test coverage to 82,5 % #2582

MizukiTemma opened this issue Dec 5, 2023 · 10 comments · Fixed by #2620 or #2669
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😱 effort: high Big change, which requires >12h
Milestone
24Q2

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Dec 5, 2023 •
edited by JoeyStk
Loading

Motivation

As a part of our "Zero bug policy" let us increase the test coverage continueing from #2492

Proposed Solution

Goal for the end of March 2024: 82,5%
Current coverage:

Alternatives

User Story

Additional Context

For more information see #2492
The goal percentage can be adjusted after all the test related PRs are closed that are currently open.

Design Requirements
@MizukiTemma MizukiTemma added the 💡 feature New feature or request label Dec 5, 2023
@MizukiTemma MizukiTemma added this to the 24Q1 milestone Dec 5, 2023
@MizukiTemma MizukiTemma mentioned this issue Dec 5, 2023
Open
33 tasks
@svenseeberg svenseeberg added 😱 effort: high Big change, which requires >12h ❗ prio: medium Should be scheduled in the forseeable future. labels Dec 6, 2023
@MizukiTemma
Copy link
Member Author

Please leave comments here which part will be worked on, when you start, to avoid multiple people working on the same parts.

@MizukiTemma MizukiTemma mentioned this issue Dec 13, 2023
Merged
8 tasks
@JoeyStk
Copy link
Contributor

JoeyStk commented Dec 17, 2023 •
edited
Loading

Peter and I decided to write tests for page_form_view.py :).

@seluianova
Copy link
Contributor

seluianova commented Jan 11, 2024 •
edited
Loading

@MariaKabanova and I will take hix.py & textlab_api_client.py & hix_signals.py

@MizukiTemma
Copy link
Member Author

I'll take language tree.

@MizukiTemma MizukiTemma mentioned this issue Jan 24, 2024
Merged
@MizukiTemma
Copy link
Member Author

MizukiTemma commented Jan 31, 2024 •
edited
Loading

Sorry, closed accidentally by my latest PR. Still 0,5% to go 😅

@MizukiTemma MizukiTemma reopened this Jan 31, 2024
@MariaKabanova MariaKabanova mentioned this issue Feb 21, 2024
Merged
@MariaKabanova MariaKabanova linked a pull request Feb 21, 2024 that will close this issue
Add tests for HIX signals #2669
Merged
@MizukiTemma MizukiTemma mentioned this issue Mar 12, 2024
Merged
@JoeyStk JoeyStk mentioned this issue Mar 30, 2024
Merged
@JoeyStk JoeyStk added ‼️ prio: high Needs to be resolved ASAP. and removed ❗ prio: medium Should be scheduled in the forseeable future. labels Apr 3, 2024
@JoeyStk JoeyStk modified the milestones: 24Q1, 24Q2 Apr 3, 2024
@seluianova
Copy link
Contributor

0,4% to go :)

@seluianova seluianova reopened this Apr 22, 2024
@JoeyStk
Copy link
Contributor

JoeyStk commented May 1, 2024

And we're back to 81,7% 😅

@timobrembeck
Copy link
Member

And we're back to 81,7% 😅

Well, that's on me 😇
And will be fixed with #2772 hopefully.

@MizukiTemma
Copy link
Member Author

I hope #2696 will bring it up again 👀

@MariaKabanova MariaKabanova mentioned this issue May 3, 2024
Merged
@MizukiTemma
Copy link
Member Author

We've reached 82,5% 🎉

Let's keep this good coverage 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😱 effort: high Big change, which requires >12h
Projects
None yet
Milestone
24Q2
5 participants
@svenseeberg @timobrembeck @JoeyStk @MizukiTemma @seluianova