Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to replace utf-8 domain links in broken link checker #2646

Closed
timobrembeck opened this issue Feb 10, 2024 · 0 comments · Fixed by #2648
Closed

Not possible to replace utf-8 domain links in broken link checker #2646

timobrembeck opened this issue Feb 10, 2024 · 0 comments · Fixed by #2648
Assignees
@timobrembeck
Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working
Milestone
24Q1

Comments

@timobrembeck
Copy link
Member

Describe the Bug

While it's possible to add links with utf-8 domains in the content now (see #2628), the broken link checker still applies urlencoding when replacing URLs.

Steps to Reproduce

  1. Go to broken link checker
  2. Replace any link e.g. by https://www.bafög.de/
  3. See that the link was converted to https://www.baf%C3%B6g.de/

Expected Behavior

Domains containing utf-8 characters should not be urlencoded

Actual Behavior

They are
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timobrembeck timobrembeck

Labels
‼️ prio: high Needs to be resolved ASAP. 🐛 bug Something isn't working
Projects
None yet
Milestone
24Q1
Development

Successfully merging a pull request may close this issue.

Allow the central link replacement of URLs with UTF-8 characters digitalfabrik/integreat-cms
1 participant
@timobrembeck