Fix HIX value diff when page content has nested tags #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 4b21da4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.0% (0.0% change). View more on Code Climate. |
seluianova
force-pushed
the
bugfix/hix-value-difference
branch
from
6ac39d6
to
0b9573e
Compare
seluianova
force-pushed
the
bugfix/hix-value-difference
branch
from
0b9573e
to
328bc5d
Compare
|
Added another small HIX-related fix for #2621 |
seluianova
commented
Feb 12, 2024
JoeyStk
approved these changes
Feb 12, 2024
seluianova
force-pushed
the
bugfix/hix-value-difference
branch
from
a939e55
to
4b21da4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Using root.iter() was not a good choice to iterate over the paragraphs, because it goes "one-way" deep into the nested elements.
For example, if a page has the following structure:
<div><p>Some image</p><p><a href="some.image"><img src="some.image" alt=""></a></p><p> </p></div>The iteration will proceed as follows:
And the last p-node will not be processed.
Proposed changes
Use list(root) instead of root.iter()
Side effects
No?
Resolved issues
Another follow-up to #2577
UPD: added another small HIX-related fix
Fixes: #2621
Pull Request Review Guidelines