Fix HIX value difference between CMS and Textlab Online service #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seluianova
force-pushed
the
bugfix/hix-text-normalization
branch
from
873d282
to
03324b6
Compare
|
Code Climate has analyzed commit 03324b6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.1% (0.0% change). View more on Code Climate. |
MizukiTemma
approved these changes
Feb 27, 2024
david-venhoff
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
It was discovered that the HIX value in https://textlab.online and in CMS is not identical:
Proposed changes
As I found, TextLab Online uses
<br>for line breaks, while we used\r\n.And that seems to be the root cause of the observed difference.
Then when I changed the line breaks in our text normalization function, I found that this actually makes the entire function unnecessary. Because it fixed all of our previous problems with the HIX value difference that I was aware of 馃檲
Including:
etc.
Side effects
I tested everything I could think of, but I may have missed something.
So additional testing is certainly welcomed.
Resolved issues
Fixes: #
Pull Request Review Guidelines