Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Poi category icons #2698

Closed
f1sh1918 opened this issue Mar 14, 2024 · 1 comment · Fixed by #2729
Closed

Add Poi category icons #2698

f1sh1918 opened this issue Mar 14, 2024 · 1 comment · Fixed by #2729
Assignees
@MizukiTemma
Labels
🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request ☺️ effort: low Should be doable in <4h
Milestone
24Q2

Comments

@f1sh1918
Copy link

Motivation

For malte and netzwerk obdach we need two new category icons

Proposed Solution

Please make the new icons available via dropdown and deliver it to the frontend via api:

  • mental_health
  • shelter

Find new svg icons here:
integreat_categories_cms.zip

api should deliver <icon_name>_<colorHex>
@f1sh1918 f1sh1918 added the 💡 feature New feature or request label Mar 14, 2024
@timobrembeck timobrembeck added this to the 24Q2 milestone Mar 14, 2024
@timobrembeck timobrembeck added 🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. ☺️ effort: low Should be doable in <4h labels Mar 14, 2024
@MizukiTemma MizukiTemma self-assigned this Mar 20, 2024
@MizukiTemma
Copy link
Member

MizukiTemma commented Apr 3, 2024 •
edited

@f1sh1918
Are the new icons broken? When I open the svg data of a new icon nothing will be shown, while existing icons are correctly shown... 🤔 I adjusted them for use in the CMS.

api should deliver <icon_name>_<colorHex>

Currently "icon" and "color" are delivered. Should <icon_name>_<colorHex> be delivered in addition to them or now only <icon_name>_<colorHex> and no independent "icon" and "color"?

@MizukiTemma MizukiTemma mentioned this issue Apr 3, 2024
Merged
@PeterNerlich PeterNerlich mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MizukiTemma MizukiTemma

Labels
🍼 good first issue Good for newcomers ‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
24Q2
Development

Successfully merging a pull request may close this issue.

Add new POI category icons digitalfabrik/integreat-cms
3 participants
@timobrembeck @f1sh1918 @MizukiTemma