Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page with content reports "successfully updated" instead of "no changes" #2673

Open
PeterNerlich opened this issue Feb 27, 2024 · 1 comment · May be fixed by #2798
Open

Page with content reports "successfully updated" instead of "no changes" #2673

PeterNerlich opened this issue Feb 27, 2024 · 1 comment · May be fixed by #2798
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@PeterNerlich
Copy link
Contributor

Describe the Bug

Because we try to normalize the page content before saving it to the database in a format different to the one that tinymce exports, django always reports that the content field changed (except on empty pages), even when just clicking "Update".

This should largely be fixed by #2668

Steps to Reproduce

  1. Go to a page with >1 lines of content
  2. Compare the source in tinymce with the content in the database (e.g. via django admin) → They are different (e.g. <br> vs. \r\n)
  3. Click on Update

Expected Behavior

The page should show No changes detected, but date refreshed

Actual Behavior

The page shows Page "<page name>" was successfully updated

@PeterNerlich PeterNerlich added the 🐛 bug Something isn't working label Feb 27, 2024
@seluianova
Copy link
Contributor

seluianova commented Feb 28, 2024

This should largely be fixed by #2668

Not really :)
In 2668, only the text in the request to TextLab is updated.
This doesn’t affect the content we save to the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment