Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor clean_content in custom_content_model_form #2849

Closed
MizukiTemma opened this issue Jun 14, 2024 · 1 comment · Fixed by #2850
Closed

Refactor clean_content in custom_content_model_form #2849

MizukiTemma opened this issue Jun 14, 2024 · 1 comment · Fixed by #2850
Assignees
@JoeyStk
Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future.
Milestone
24Q3

Comments

@MizukiTemma
Copy link
Member

Motivation

The function clean_content in custom_content_model_form has 97 lines with two pylint rules disabled. It is probably time to refactor it for clean code and better code standard.

Proposed Solution

Devide the tasks of this fucntion into multiple of smaller functions?

Alternatives

Other approaches are welcmed too :)

User Story

Additional Context

Design Requirements
@MizukiTemma MizukiTemma added the 🔨 enhancement This improves an existing feature label Jun 14, 2024
@MizukiTemma MizukiTemma added this to the 24Q3 milestone Jun 14, 2024
@MizukiTemma MizukiTemma mentioned this issue Jun 14, 2024
Merged
@MizukiTemma MizukiTemma added the ⁉️ prio: low Not urgent, can be resolved in the distant future. label Jun 14, 2024
@MizukiTemma
Copy link
Member Author

Fell free to move to any milestone.

@JoeyStk JoeyStk self-assigned this Jun 16, 2024
@JoeyStk JoeyStk mentioned this issue Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeyStk JoeyStk

Labels
🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future.
Projects
None yet
Milestone
24Q3
Development

Successfully merging a pull request may close this issue.

Refactor clean_content digitalfabrik/integreat-cms
2 participants
@JoeyStk @MizukiTemma