Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom API-Key #269

Closed
batcapricorn opened this issue Dec 7, 2021 · 6 comments · Fixed by #374
Closed

Custom API-Key #269

batcapricorn opened this issue Dec 7, 2021 · 6 comments · Fixed by #374
Assignees
@timobrembeck
Labels
Prio:Medium
Milestone
Backlog

Comments

@batcapricorn
Copy link
Contributor

Motivation

Give (super-) users the possibility to create custom API-Keys like "Kreis-Olpe-Key1225"
@batcapricorn batcapricorn added this to the V2 milestone Dec 7, 2021
@batcapricorn batcapricorn added this to To do in Kanban Dec 7, 2021
@batcapricorn batcapricorn removed this from To do in Kanban Jan 4, 2022
@timobrembeck timobrembeck self-assigned this Jul 25, 2022
@timobrembeck
Copy link
Member

@dkehne This kind of contradicts the requirements of issue #285.
Should it be possible to set the key completely user-defined or should the restrictions be enforced?

@dkehne
Copy link

dkehne commented Jul 25, 2022 •
edited

#285 is a guideline for system-generated keys (10 digit no special chars, only capital letters)
Nevertheless it should be possible to manually set a key. this should be AT LEAST 10 chars (can be longer). No special chars allowed, BUT numbers/letters.

@dkehne
Copy link

dkehne commented Jul 25, 2022

Kreis-Olpe-Key1225 would not be possible but

KREISOLPEKEY1225

@maxammann
Copy link
Member

Hallo Timo!

@timobrembeck
Copy link
Member

Kreis-Olpe-Key1225 would not be possible but

KREISOLPEKEY1225

No, it would be KREIS0LPEKEY1225 with a zero instead of an O. Not sure if that really helps with ambiguities 😉

@dkehne
Copy link

dkehne commented Jul 25, 2022

The 0/O Rule should be only valid for system generated Keys.

@timobrembeck timobrembeck mentioned this issue Jul 25, 2022
Merged
@timobrembeck timobrembeck mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timobrembeck timobrembeck

Labels
Prio:Medium
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Refactor API key handling digitalfabrik/lunes-cms
4 participants
@maxammann @dkehne @timobrembeck @batcapricorn