Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to XML #1

Open
pyrabbit opened this issue Sep 25, 2018 · 4 comments
Open

Back to XML #1

pyrabbit opened this issue Sep 25, 2018 · 4 comments

Comments

@pyrabbit
Copy link

Thank you for your work on this project. It is more reliable than the active_support alternative I was working with. I am interested in a feature that can reproduce the source XML from the generated Ruby hash. Is this within the scope of this project and would you be open to me contributing that feature?

@digitalheir
Copy link
Owner

Hi, thanks for the sugestion! It's been a long time since I made this project. I'm kind of surprised I didn't make a function to generate an XML string from hash. It's a good idea and I'm definitely open to contributions!

@pyrabbit
Copy link
Author

@digitalheir thanks for the quick reply. this library has stood the test of time as it still works fairly reliably for me. i am not to the point in my project yet where we will be translating back to XML but I will probably reach that point in the upcoming month. I look forward to contributing when I get to that point!

@digitalheir
Copy link
Owner

I suppose we should add a method that creates Nokogiri nodes and then leverage Nokogiri's own XML renderer. Since this project depends on Nokogiri already...

@pyrabbit
Copy link
Author

that makes a lot of sense -- i am still digesting a lot of what Nokogiri has to offer but I think by the time I am done I will be knowledgeable enough to implement something that does as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants