-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Localize assets from CDNs #2
Comments
We should probably also provide a way to localize ALL assets. Packages could provide a way to tell |
Brain dump with @promatik @basset('https://cdnjs.cloudflare.com/ajax/libs/tinymce/6.2.0/tinymce.min.js')
/public/basset/cdnjs.cloudflare.com/ajax/libs/tinymce/6.2.0/tinymce.min.js
---
php artisan basset:install
- add to .gitignore
- add to composer.json
php artisan basset:internalize |
Can't wait to do it 🙌 |
This is fixed by #14 |
This same package could/should also solve the problem of localizing CDN assets.
We could add:
http://
,https://
or://
), we check if it doesn't also exist on the local file system (storage/app/public/assets/localized/
);storage/app/public/assets/localized/
so it can be used from there next time;After that, the docs could also have a section with something like:
The text was updated successfully, but these errors were encountered: