Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Consider greater input encapsulation with lifecycle meta-arguments #99

Open
artis3n opened this issue Feb 2, 2023 · 0 comments
Labels
enhancement New feature or request terraform Pull requests that update Terraform code

Comments

@artis3n
Copy link
Collaborator

artis3n commented Feb 2, 2023

Is your feature request related to a problem? Please describe.

Using the module requires learning all about the GitHub OIDC token and how to combine claims to achieve your desired configuration. We have custom internal tooling to encapsulate these details, and I'd love to add encapsulation to the native properties of this module.

Describe the solution you'd like

We could allow folks to fully customize the bound_subject and additional_claims while also offering syntactic sugar in which they ask for a certain type of role, e.g. branch binding, and pass in the name of their branch, and we construct the appropriate bound_subject behind the scenes with validation using https://developer.hashicorp.com/terraform/language/expressions/custom-conditions.

Describe alternatives you've considered

This not being useful.

Additional context

@artis3n artis3n added enhancement New feature or request terraform Pull requests that update Terraform code labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terraform Pull requests that update Terraform code
Projects
None yet
Development

No branches or pull requests

1 participant