Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont cap grace period at 0 for soft evictions #19

Open
cjroebuck opened this issue Dec 5, 2019 · 2 comments
Open

dont cap grace period at 0 for soft evictions #19

cjroebuck opened this issue Dec 5, 2019 · 2 comments

Comments

@cjroebuck
Copy link

the following flag is currently defaulted on the kubelet: --eviction-max-pod-grace-period="0" which renders any terminationGracePeriodSeconds set on the pod spec useless when said pod is (softly) evicted.

Would be nice to set this to a larger period (300s / 5m?) in order to support pods that need to terminate gracefully when handling long running connections or processes.

Pods that are evicted due to 'soft' thresholds being met are effectively being hard-killed which doesn't seem right to me.

@timoreimann
Copy link
Contributor

@cjroebuck 👋

Being able to use soft evictions in DOKS sounds like a reasonable request. Apart from the grace period itself, I believe the major challenge is to figure out what the right thresholds are for the individual resource types (memory, disk, etc.). Ideally, we want to be able to use a default value that works for most (all?) clusters.

@timoreimann
Copy link
Contributor

timoreimann commented Dec 5, 2019

@cjroebuck would it be possible for you to set resource requests on your affected workload(s) high enough so that pod evictions do not even become an issue in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants