Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stringData for Kubernetes Secret containing DO Token. #51

Closed
andrewsykim opened this issue Oct 21, 2017 · 2 comments
Closed

Use stringData for Kubernetes Secret containing DO Token. #51

andrewsykim opened this issue Oct 21, 2017 · 2 comments
Labels
Hacktoberfest

Comments

@andrewsykim
Copy link
Contributor

The current examples use data in Kubernetes secrets which requires you to base64 encode your secrets. Kuberetes now supports stringData which is backwards compatible where the kubelet would end up consuming the data in base64 but we can use string data instead.

In #49, we had a discussion around how we should handle new line characters when we base64 encode the DO token, this would address it.

More details here kubernetes/kubernetes#19575.
@andrewsykim andrewsykim mentioned this issue Oct 21, 2017
Merged
@bhcleek
Copy link
Contributor

bhcleek commented Oct 22, 2017

Sgtm

@klausenbusk klausenbusk mentioned this issue Nov 18, 2017
Merged
@klausenbusk
Copy link
Contributor

PR opened: #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klausenbusk @bhcleek @andrewsykim