Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Allow multiple routes (Closes: #567). #571

Merged
merged 2 commits into from Feb 1, 2021
Merged

Conversation

andrewsomething
Copy link
Member

This PR addresses #567 by allowing multiple routes for a service or static site. As workers and jobs are not publicly rotatable, this moves the attribute out of the appSpecComponentBase() and directly into appSpecServicesSchema() and appSpecStaticSiteSchema()

Copy link
Member

@ChiefMateStarbuck ChiefMateStarbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsomething andrewsomething merged commit b7ffd57 into main Feb 1, 2021
@andrewsomething andrewsomething deleted the asb/issues/567 branch February 1, 2021 19:17
andrewsomething added a commit that referenced this pull request Apr 26, 2021
* apps: Allow multiple routes (Closes: #567).

* apps: Workers should not have routes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants